chore(argo-cd)!: Remove apps, appprojs and deprecated features (#1417)

* feat(argo-cd): move server additionalApplications/additionalProjects to argocd-apps chart
Signed-off-by: yu-croco <yuki.kita22@gmail.com>

* Remove deprecated features
Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* chore(argo-cd): improve release note
Signed-off-by: yu-croco <yu.croco@gmail.com>

Co-authored-by: yu-croco <yuki.kita22@gmail.com>
Co-authored-by: Petr Drastil <petr.drastil@gmail.com>

charts/argo-cd/templates/NOTES.txt

@@ -1,9 +1,3 @@
-{{- if or .Values.configs.repositoryCredentials .Values.server.config.repositories }}
-WARNING: You are using `configs.repositoryCredentials` and/or `server.config.repositories` parameter that are DEPRECATED
-Instead, use `configs.repositoryTemplates` and/or `configs.repositories` parameters
-Read More about here: https://argo-cd.readthedocs.io/en/latest/operator-manual/declarative-setup/#legacy-behaviour
-
-{{- end}}
 In order to access the server UI you have the following options:
 
 1. kubectl port-forward service/{{include "argo-cd.fullname" . }}-server -n {{ .Release.Namespace }} 8080:443

charts/argo-cd/templates/argocd-application-controller/statefulset.yaml

@@ -1,6 +1,6 @@
 {{- $redisHa := (index .Values "redis-ha") -}}
 apiVersion: apps/v1
-kind: {{ .Values.controller.enableStatefulSet | ternary "StatefulSet" "Deployment" }}
+kind: StatefulSet
 metadata:
   name: {{ template "argo-cd.controller.fullname" . }}
   labels:
@@ -10,9 +10,7 @@ spec:
   selector:
     matchLabels:
       {{- include "argo-cd.selectorLabels" (dict "context" . "name" .Values.controller.name) | nindent 6 }}
-  {{- if  .Values.controller.enableStatefulSet }}
   serviceName: {{ template "argo-cd.controller.fullname" . }}
-  {{- end }}
   revisionHistoryLimit: 5
   replicas: {{ .Values.controller.replicas }}
   template:

charts/argo-cd/templates/argocd-configs/applications.yaml

@@ -1,42 +0,0 @@
-{{- range .Values.server.additionalApplications }}
----
-apiVersion: argoproj.io/v1alpha1
-kind: Application
-metadata:
-  {{- with .additionalAnnotations }}
-  annotations:
-    {{- range $key, $value := . }}
-    {{ $key }}: {{ $value | quote }}
-    {{- end }}
-  {{- end }}
-  {{- with .additionalLabels }}
-  labels:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-  name: {{ .name }}
-  {{- with .namespace }}
-  namespace: {{ . }}
-  {{- end }}
-  {{- with .finalizers }}
-  finalizers:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-spec:
-  project: {{ tpl .project $ }}
-  source:
-    {{- toYaml .source | nindent 4 }}
-  destination:
-    {{- toYaml .destination | nindent 4 }}
-  {{- with .syncPolicy }}
-  syncPolicy:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-  {{- with .ignoreDifferences }}
-  ignoreDifferences:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-  {{- with .info }}
-  info:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-{{- end }}

charts/argo-cd/templates/argocd-configs/projects.yaml

@@ -1,62 +0,0 @@
-{{- range .Values.server.additionalProjects }}
----
-apiVersion: argoproj.io/v1alpha1
-kind: AppProject
-metadata:
-  {{- with .additionalAnnotations }}
-  annotations:
-    {{- range $key, $value := . }}
-    {{ $key }}: {{ $value | quote }}
-    {{- end }}
-  {{- end }}
-  {{- with .additionalLabels }}
-  labels:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-  name: {{ .name }}
-  {{- with .namespace }}
-  namespace: {{ . }}
-  {{- end }}
-  {{- with .finalizers }}
-  finalizers:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-spec:
-  description: {{ .description }}
-  sourceRepos:
-    {{- toYaml .sourceRepos | nindent 4 }}
-  destinations:
-    {{- toYaml .destinations | nindent 4 }}
-  {{- with .clusterResourceWhitelist }}
-  clusterResourceWhitelist:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-  {{- with .clusterResourceBlacklist }}
-  clusterResourceBlacklist:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-  {{- with .namespaceResourceBlacklist }}
-  namespaceResourceBlacklist:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-  {{- with .namespaceResourceWhitelist }}
-  namespaceResourceWhitelist:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-  {{- with .orphanedResources }}
-  orphanedResources:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-  {{- with .roles }}
-  roles:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-  {{- with .syncWindows }}
-  syncWindows:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-  {{- with .signatureKeys }}
-  signatureKeys:
-    {{- toYaml . | nindent 4 }}
-  {{- end }}
-{{- end }}

charts/argo-cd/templates/argocd-configs/repository-credentials-secret-legacy.yaml

@@ -1,13 +0,0 @@
-{{- if .Values.configs.repositoryCredentials }}
-apiVersion: v1
-kind: Secret
-metadata:
-  name: argocd-repository-credentials
-  labels:
-    {{- include "argo-cd.labels" (dict "context" . "component" .Values.server.name "name" "secret") | nindent 4 }}
-type: Opaque
-data:
-{{- range $key, $value := .Values.configs.repositoryCredentials }}
-  {{ $key }}: {{ $value | b64enc }}
-{{- end }}
-{{- end }}