DevFW-CICD/argocd-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(argo-rollouts): Support extraArgs for controller and dashboard (#978)

Browse source 
* feat(argo-rollouts): Support extraArgs for controller and dashboard

Adding support for additional arguments that are passed to the controller and the dashboard.
Following the pattern of other Argo charts by re-using the name `extraArgs` for the value.

Refs: https://github.com/argoproj/argo-helm/issues/969
Signed-off-by: Sebastian J <zeeman@zeeman.de>

* Update charts/argo-rollouts/templates/controller/deployment.yaml

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Sebastian J <zeeman@zeeman.de>

* Update charts/argo-rollouts/templates/dashboard/deployment.yaml

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Sebastian J <zeeman@zeeman.de>

* PR comments

Signed-off-by: Sebastian J <zeeman@zeeman.de>

* Fix newly added parameters in README

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

* Fix changelog keyword

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
This commit is contained in:
Sebastian J 2021-10-18 08:29:19 -04:00 • committed by GitHub
parent a992c96053
commit 85f3039265
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 19 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
charts/argo-rollouts/README.md
View file

@ -38,6 +38,7 @@ If dashboard is installed by `--set dashboard.enabled=true`, checkout the argo-r
| controller.image.registry | string | `quay.io` | Registry to use |
| controller.image.repository | string | `"argoproj/argo-rollouts"` | Repository to use |
| controller.image.tag | string | `""` | Overrides the image tag (default is the chart appVersion) |
| controller.extraArgs | list | `[]` | Additional arguments for the controller. A list of flags. |
| controller.resources | object | `{}` | Resource limits and requests for the controller pods. |
| controller.tolerations | list | `[]` | [Tolerations for use with node taints](https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/) |
| controller.affinity | object | `{}` | [Assign custom affinity rules to the deployment](https://kubernetes.io/docs/concepts/configuration/assign-pod-node/) |
@ -63,6 +64,7 @@ If dashboard is installed by `--set dashboard.enabled=true`, checkout the argo-r
| dashboard.image.registry | string | `quay.io` | Registry to use |
| dashboard.image.repository | string | `"argoproj/kubectl-argo-rollouts"` | Repository to use |
| dashboard.image.tag | string | `""` | Overrides the image tag (default is the chart appVersion) |
| dashboard.extraArgs | list | `[]` | Additional arguments for the dashboard. A list of flags. |
| dashboard.resources | object | `{}` | Resource limits and requests for the dashboard pods. |
| dashboard.tolerations | list | `[]` | [Tolerations for use with node taints](https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/) |
| dashboard.affinity | object | `{}` | [Assign custom affinity rules to the deployment](https://kubernetes.io/docs/concepts/configuration/assign-pod-node/) |