DevFW-CICD/argocd-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(argo-workflows): Allow setting the metrics port name (#934)

Browse source 
* Allow setting the metrics port name
Here, we scrape every pod that has a .*-metrics port here
But the helm chart is locked to `metrics` which our Prometheus doesn't see

This PR will make it configurable with a default value of `metrics`

Signed-off-by: Julien Duchesne <julien.duchesne@grafana.com>

* Bump version

Signed-off-by: Julien Duchesne <julien.duchesne@grafana.com>

* Bump minor version

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
This commit is contained in:
Julien Duchesne 2021-09-17 15:51:13 -04:00 • committed by GitHub
parent 7477b33cba
commit c7584ab51d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml
View file

@ -75,7 +75,7 @@ spec:
resources:
{{- toYaml .Values.controller.resources | nindent 12 }}
ports:
- name: metrics
- name: {{ .Values.controller.metricsConfig.portName }}
containerPort: {{ .Values.controller.metricsConfig.port }}
- containerPort: 6060
livenessProbe: {{ .Values.controller.livenessProbe | toYaml | nindent 12 }}