DevFW-CICD/argocd-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(argo-workflows): Fix Helm chart to correctly reference Kubernetes version in conditional check for HPA apiVersion (#2029)

Browse source 
* add a fix for argo workflows hpa

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

* add description for the fix

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

* update readme

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

* remove apiVersionOverrides from readme

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

* fix linting

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>

---------

Signed-off-by: ryanpark0203 <108246291+ryanpark0203@users.noreply.github.com>
Co-authored-by: Aikawa <yu.croco@gmail.com>
Co-authored-by: Jason Meridth <jmeridth@gmail.com>
This commit is contained in:
ryanpark0203 2023-05-09 13:41:54 +10:00 • committed by GitHub
parent 395abc5435
commit c8b47cf060
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
charts/argo-workflows/templates/_helpers.tpl
View file

@ -160,7 +160,7 @@ Return the appropriate apiVersion for autoscaling
{{- define "argo-workflows.apiVersion.autoscaling" -}}
{{- if .Values.apiVersionOverrides.autoscaling -}}
{{- print .Values.apiVersionOverrides.autoscaling -}}
{{- else if semverCompare "<1.23-0" (include "argo-cd.kubeVersion" .) -}}
{{- else if semverCompare "<1.23-0" (include "argo-workflows.kubeVersion" .) -}}
{{- print "autoscaling/v2beta1" -}}
{{- else -}}
{{- print "autoscaling/v2" -}}

2
charts/argo-workflows/templates/server/server-deployment-hpa.yaml
View file

@ -1,5 +1,5 @@
{{- if and .Values.server.enabled .Values.server.autoscaling.enabled }}
apiVersion: autoscaling/v2beta1
apiVersion: {{ include "argo-workflows.apiVersion.autoscaling" . }}
kind: HorizontalPodAutoscaler
metadata:
name: {{ template "argo-workflows.server.fullname" . }}