DevFW-CICD/argocd-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat(argo-rollouts): Add notification secret and configmap (#1163)

Browse source 
* fixing the error on the argo rollouts controller needing the notifications configmap and rollout

Signed-off-by: Ian Muge <ian.muge@ardoq.com>

* bump chart version

Signed-off-by: Ian Muge <ian.muge@ardoq.com>

* updating changelog

Signed-off-by: Ian Muge <ian.muge@ardoq.com>

* fix structure to be simialr to argocd-notification as suggested

Signed-off-by: Ian Muge <ian.muge@ardoq.com>

* Bump Minor version as we are adding a new feature

Signed-off-by: Ian Muge <ian.muge@ardoq.com>

* Updated helm docs, all tests are green, locally

Signed-off-by: Ian Muge <ian.muge@ardoq.com>

* Apply changes from code review

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
This commit is contained in:
Ian Muge 2022-03-14 22:12:41 +01:00 • committed by GitHub
parent dde043a055
commit c8f0471bd0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 70 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
charts/argo-rollouts/README.md
View file

@ -48,6 +48,11 @@ If dashboard is installed by `--set dashboard.enabled=true`, checkout the argo-r
| keepCRDs | bool | `true` | Keep CRD's on helm uninstall |
| kubeVersionOverride | string | `""` | Override the Kubernetes version, which is used to evaluate certain manifests |
| nameOverride | string | `nil` | String to partially override "argo-rollouts.fullname" template |
| notifications.notifiers | object | `{}` | Configures notification services |
| notifications.secret.create | bool | `false` | Whether to create notifications secret |
| notifications.secret.items | object | `{}` | Generic key:value pairs to be inserted into the notifications secret |
| notifications.templates | object | `{}` | Notification templates |
| notifications.triggers | object | `{}` | The trigger defines the condition when the notification should be sent |
### Controller
@ -148,4 +153,4 @@ Autogenerated from chart metadata using [helm-docs](https://github.com/norwoodj/
[Node selector]: https://kubernetes.io/docs/user-guide/node-selection/
[probe]: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#container-probes
[Tolerations]: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
[values.yaml]: https://github.com/argoproj/argo-helm/blob/argo-rollouts-2.10.0/charts/argo-rollouts/values.yaml
[values.yaml]: https://github.com/argoproj/argo-helm/blob/argo-rollouts-2.11.0/charts/argo-rollouts/values.yaml