feat(argo-rollouts): Allow setting the type for the dashboard service (#973)

* feat: Allow setting the type for the dashboard service. (We have a requirement
to run it as NodePort). Default to what it is if not set.

Signed-off-by: Dan Tulovsky <dant@lightstep.com>

* Bump Chart version.

Signed-off-by: Dan Tulovsky <dant@lightstep.com>

* Add serviceType into values.yaml

Signed-off-by: Dan Tulovsky <dant@lightstep.com>

* Address review comments:

Remove old changes annotation.
Rename serviceType to service.type.

Signed-off-by: Dan Tulovsky <dant@lightstep.com>

* Bump Chart version.

Signed-off-by: Dan Tulovsky <dant@lightstep.com>

* Fix typo

Signed-off-by: Dan Tulovsky <dant@lightstep.com>

* FIx indentation (lint error)

Signed-off-by: Dan Tulovsky <dant@lightstep.com>

* Update README

Signed-off-by: Dan Tulovsky <dant@lightstep.com>

* Update charts/argo-rollouts/README.md

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Dan Tulovsky <dant@lightstep.com>

* Apply suggestions from code review

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

* fix changelog

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

* docs: Add warning about exposing the Dashboard via Service type

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

charts/argo-rollouts/values.yaml

@@ -125,6 +125,8 @@ dashboard:
   podSecurityContext:
     runAsNonRoot: true
   containerSecurityContext: {}
+  service:
+    type: ClusterIP
   serviceAccount:
     create: true
     annotations: {}