DevFW-CICD/argocd-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(argo-cd): Remove namespace from cluster scope resource (#2833)

Browse source 
* Remove namespace from cluster scope resource

A few resources I noticed had the namespace set for cluster scoped resources.

Signed-off-by: Jonny Langefeld <jonny.langefeld@snowflake.com>

* Update clusterrole.yaml

Signed-off-by: Jonny Langefeld <jonny.langefeld@snowflake.com>

* chore: Apply changes from code review

Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>

---------

Signed-off-by: Jonny Langefeld <jonny.langefeld@snowflake.com>
Signed-off-by: Marco Maurer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Maurer (-Kilchhofer) <mkilchhofer@users.noreply.github.com>
This commit is contained in:
Jonny Langefeld 2024-09-23 10:27:10 -07:00 • committed by GitHub
parent b50a0731e7
commit edd04f6ec8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
charts/argo-cd/templates/argocd-applicationset/clusterrole.yaml
View file

@ -3,7 +3,6 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: {{ include "argo-cd.applicationSet.fullname" . }}
namespace: {{ include "argo-cd.namespace" . }}
labels:
{{- include "argo-cd.labels" (dict "context" . "component" .Values.applicationSet.name "name" .Values.applicationSet.name) | nindent 4 }}
rules:

1
charts/argo-cd/templates/argocd-applicationset/clusterrolebinding.yaml
View file

@ -3,7 +3,6 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: {{ template "argo-cd.applicationSet.fullname" . }}
namespace: {{ include "argo-cd.namespace" . }}
labels:
{{- include "argo-cd.labels" (dict "context" . "component" .Values.applicationSet.name "name" .Values.applicationSet.name) | nindent 4 }}
roleRef: