* feat(argo-rollouts): Add ability to define dashboard service node port
Signed-off-by: Jean Mainguy <9969006+jhandguy@users.noreply.github.com>
* Apply changes from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat(argo-rollouts): +LB service.type for dashboard svc
Signed-off-by: Maciej Lasyk <maciej@lasyk.info>
* Apply changes from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat: Allow setting the type for the dashboard service. (We have a requirement
to run it as NodePort). Default to what it is if not set.
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Bump Chart version.
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Add serviceType into values.yaml
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Address review comments:
Remove old changes annotation.
Rename serviceType to service.type.
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Bump Chart version.
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Fix typo
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* FIx indentation (lint error)
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Update README
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Update charts/argo-rollouts/README.md
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Dan Tulovsky <dant@lightstep.com>
* Apply suggestions from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* fix changelog
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* docs: Add warning about exposing the Dashboard via Service type
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat(argo-rollouts): Support extraArgs for controller and dashboard
Adding support for additional arguments that are passed to the controller and the dashboard.
Following the pattern of other Argo charts by re-using the name `extraArgs` for the value.
Refs: https://github.com/argoproj/argo-helm/issues/969
Signed-off-by: Sebastian J <zeeman@zeeman.de>
* Update charts/argo-rollouts/templates/controller/deployment.yaml
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Sebastian J <zeeman@zeeman.de>
* Update charts/argo-rollouts/templates/dashboard/deployment.yaml
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Signed-off-by: Sebastian J <zeeman@zeeman.de>
* PR comments
Signed-off-by: Sebastian J <zeeman@zeeman.de>
* Fix newly added parameters in README
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Fix changelog keyword
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* feat(argo-rollouts): add dashboard deployment and service
credit: the implemention is inspired by the work from
Andrii Perenesenko <andrii.perenesenko@gmail.com>.
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
* Apply suggestions from code review
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
* Add components to selectlabels
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
* Bump major version and add upgrading note
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
* fix: Documentation on dashboard values, change annotations
Signed-off-by: Hui Kang <hui.kang@salesforce.com>
* feat: Enable dashboard during chart testing
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Co-authored-by: Hui Kang <hui.kang@salesforce.com>
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
