Update go dependencies

vendor/go.opencensus.io/stats/internal/validation.go

@@ -1,28 +0,0 @@
-// Copyright 2018, OpenCensus Authors
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-package internal // import "go.opencensus.io/stats/internal"
-
-const (
-	MaxNameLength = 255
-)
-
-func IsPrintable(str string) bool {
-	for _, r := range str {
-		if !(r >= ' ' && r <= '~') {
-			return false
-		}
-	}
-	return true
-}

vendor/go.opencensus.io/stats/measure.go

@@ -68,21 +68,6 @@ func (m *measureDescriptor) subscribed() bool {
 	return atomic.LoadInt32(&m.subs) == 1
 }
 
-// Name returns the name of the measure.
-func (m *measureDescriptor) Name() string {
-	return m.name
-}
-
-// Description returns the description of the measure.
-func (m *measureDescriptor) Description() string {
-	return m.description
-}
-
-// Unit returns the unit of the measure.
-func (m *measureDescriptor) Unit() string {
-	return m.unit
-}
-
 var (
 	mu       sync.RWMutex
 	measures = make(map[string]*measureDescriptor)
@@ -108,8 +93,9 @@ func registerMeasureHandle(name, desc, unit string) *measureDescriptor {
 // provides methods to create measurements of their kind. For example, Int64Measure
 // provides M to convert an int64 into a measurement.
 type Measurement struct {
-	v float64
-	m *measureDescriptor
+	v    float64
+	m    Measure
+	desc *measureDescriptor
 }
 
 // Value returns the value of the Measurement as a float64.

vendor/go.opencensus.io/stats/measure_float64.go

@@ -17,13 +17,17 @@ package stats
 
 // Float64Measure is a measure for float64 values.
 type Float64Measure struct {
-	*measureDescriptor
+	desc *measureDescriptor
 }
 
 // M creates a new float64 measurement.
 // Use Record to record measurements.
 func (m *Float64Measure) M(v float64) Measurement {
-	return Measurement{m: m.measureDescriptor, v: v}
+	return Measurement{
+		m:    m,
+		desc: m.desc,
+		v:    v,
+	}
 }
 
 // Float64 creates a new measure for float64 values.
@@ -34,3 +38,18 @@ func Float64(name, description, unit string) *Float64Measure {
 	mi := registerMeasureHandle(name, description, unit)
 	return &Float64Measure{mi}
 }
+
+// Name returns the name of the measure.
+func (m *Float64Measure) Name() string {
+	return m.desc.name
+}
+
+// Description returns the description of the measure.
+func (m *Float64Measure) Description() string {
+	return m.desc.description
+}
+
+// Unit returns the unit of the measure.
+func (m *Float64Measure) Unit() string {
+	return m.desc.unit
+}

vendor/go.opencensus.io/stats/measure_int64.go

@@ -17,13 +17,17 @@ package stats
 
 // Int64Measure is a measure for int64 values.
 type Int64Measure struct {
-	*measureDescriptor
+	desc *measureDescriptor
 }
 
 // M creates a new int64 measurement.
 // Use Record to record measurements.
 func (m *Int64Measure) M(v int64) Measurement {
-	return Measurement{m: m.measureDescriptor, v: float64(v)}
+	return Measurement{
+		m:    m,
+		desc: m.desc,
+		v:    float64(v),
+	}
 }
 
 // Int64 creates a new measure for int64 values.
@@ -34,3 +38,18 @@ func Int64(name, description, unit string) *Int64Measure {
 	mi := registerMeasureHandle(name, description, unit)
 	return &Int64Measure{mi}
 }
+
+// Name returns the name of the measure.
+func (m *Int64Measure) Name() string {
+	return m.desc.name
+}
+
+// Description returns the description of the measure.
+func (m *Int64Measure) Description() string {
+	return m.desc.description
+}
+
+// Unit returns the unit of the measure.
+func (m *Int64Measure) Unit() string {
+	return m.desc.unit
+}

vendor/go.opencensus.io/stats/record.go

@@ -43,7 +43,7 @@ func Record(ctx context.Context, ms ...Measurement) {
 	}
 	record := false
 	for _, m := range ms {
-		if m.m.subscribed() {
+		if m.desc.subscribed() {
 			record = true
 			break
 		}

vendor/go.opencensus.io/stats/view/view.go

@@ -17,6 +17,7 @@ package view
 
 import (
 	"bytes"
+	"errors"
 	"fmt"
 	"reflect"
 	"sort"
@@ -26,7 +27,6 @@ import (
 	"go.opencensus.io/exemplar"
 
 	"go.opencensus.io/stats"
-	"go.opencensus.io/stats/internal"
 	"go.opencensus.io/tag"
 )
 
@@ -69,6 +69,11 @@ func (v *View) same(other *View) bool {
 		v.Measure.Name() == other.Measure.Name()
 }
 
+// ErrNegativeBucketBounds error returned if histogram contains negative bounds.
+//
+// Deprecated: this should not be public.
+var ErrNegativeBucketBounds = errors.New("negative bucket bounds not supported")
+
 // canonicalize canonicalizes v by setting explicit
 // defaults for Name and Description and sorting the TagKeys
 func (v *View) canonicalize() error {
@@ -90,9 +95,27 @@ func (v *View) canonicalize() error {
 	sort.Slice(v.TagKeys, func(i, j int) bool {
 		return v.TagKeys[i].Name() < v.TagKeys[j].Name()
 	})
+	sort.Float64s(v.Aggregation.Buckets)
+	for _, b := range v.Aggregation.Buckets {
+		if b < 0 {
+			return ErrNegativeBucketBounds
+		}
+	}
+	// drop 0 bucket silently.
+	v.Aggregation.Buckets = dropZeroBounds(v.Aggregation.Buckets...)
+
 	return nil
 }
 
+func dropZeroBounds(bounds ...float64) []float64 {
+	for i, bound := range bounds {
+		if bound > 0 {
+			return bounds[i:]
+		}
+	}
+	return []float64{}
+}
+
 // viewInternal is the internal representation of a View.
 type viewInternal struct {
 	view       *View  // view is the canonicalized View definition associated with this view.
@@ -174,11 +197,23 @@ func (r *Row) Equal(other *Row) bool {
 	return reflect.DeepEqual(r.Tags, other.Tags) && r.Data.equal(other.Data)
 }
 
-func checkViewName(name string) error {
-	if len(name) > internal.MaxNameLength {
-		return fmt.Errorf("view name cannot be larger than %v", internal.MaxNameLength)
+const maxNameLength = 255
+
+// Returns true if the given string contains only printable characters.
+func isPrintable(str string) bool {
+	for _, r := range str {
+		if !(r >= ' ' && r <= '~') {
+			return false
+		}
 	}
-	if !internal.IsPrintable(name) {
+	return true
+}
+
+func checkViewName(name string) error {
+	if len(name) > maxNameLength {
+		return fmt.Errorf("view name cannot be larger than %v", maxNameLength)
+	}
+	if !isPrintable(name) {
 		return fmt.Errorf("view name needs to be an ASCII string")
 	}
 	return nil

vendor/go.opencensus.io/stats/view/worker.go

@@ -64,11 +64,6 @@ func Find(name string) (v *View) {
 // Register begins collecting data for the given views.
 // Once a view is registered, it reports data to the registered exporters.
 func Register(views ...*View) error {
-	for _, v := range views {
-		if err := v.canonicalize(); err != nil {
-			return err
-		}
-	}
 	req := &registerViewReq{
 		views: views,
 		err:   make(chan error),

vendor/go.opencensus.io/stats/view/worker_commands.go

@@ -58,6 +58,12 @@ type registerViewReq struct {
 }
 
 func (cmd *registerViewReq) handleCommand(w *worker) {
+	for _, v := range cmd.views {
+		if err := v.canonicalize(); err != nil {
+			cmd.err <- err
+			return
+		}
+	}
 	var errstr []string
 	for _, view := range cmd.views {
 		vi, err := w.tryRegisterView(view)