DevFW-CICD/ingress-nginx-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix unit tests and comments

Browse source 
Signed-off-by: z1cheng <imchench@gmail.com>
This commit is contained in:
z1cheng 2023-06-29 14:11:51 +00:00 • committed by k8s-infra-cherrypick-robot
parent 4b6d0c0738
commit 1d8e7f4695
7 changed files with 17 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

8
internal/ingress/controller/checker_test.go
View file

@ -103,9 +103,7 @@ func TestNginxCheck(t *testing.T) {
}
}()
go func() {
if err := cmd.Wait(); err != nil {
t.Errorf("unexpected error waiting for the process: %v", err)
}
cmd.Wait() //nolint:errcheck
}()
if _, err := pidFile.Write([]byte(fmt.Sprintf("%v", pid))); err != nil {
@ -123,9 +121,7 @@ func TestNginxCheck(t *testing.T) {
})
// pollute pid file
if _, err := pidFile.Write([]byte("999999")); err != nil {
t.Errorf("unexpected error polluting the pid file: %v", err)
}
pidFile.Write([]byte("999999")) //nolint:errcheck
pidFile.Close()
t.Run("bad pid", func(t *testing.T) {