Enhance Unit Tests for Annotations

Adds unit tests for a variety of different annotations.

internal/ingress/annotations/redirect/redirect_test.go

@@ -18,12 +18,15 @@ package redirect
 
 import (
 	"net/http"
+	"net/url"
+	"reflect"
 	"strconv"
 	"testing"
 
 	extensions "k8s.io/api/extensions/v1beta1"
 
 	"k8s.io/ingress-nginx/internal/ingress/annotations/parser"
+	"k8s.io/ingress-nginx/internal/ingress/errors"
 	"k8s.io/ingress-nginx/internal/ingress/resolver"
 )
 
@@ -99,3 +102,56 @@ func TestPermanentRedirectWithCustomCode(t *testing.T) {
 		})
 	}
 }
+
+func TestTemporalRedirect(t *testing.T) {
+	rp := NewParser(resolver.Mock{})
+	if rp == nil {
+		t.Fatalf("Expected a parser.IngressAnnotation but returned nil")
+	}
+
+	ing := new(extensions.Ingress)
+
+	data := make(map[string]string, 1)
+	data[parser.GetAnnotationWithPrefix("from-to-www-redirect")] = "true"
+	data[parser.GetAnnotationWithPrefix("temporal-redirect")] = defRedirectURL
+	ing.SetAnnotations(data)
+
+	i, err := rp.Parse(ing)
+	if err != nil {
+		t.Errorf("Unexpected error with ingress: %v", err)
+	}
+	redirect, ok := i.(*Config)
+	if !ok {
+		t.Errorf("Expected a Redirect type")
+	}
+	if redirect.URL != defRedirectURL {
+		t.Errorf("Expected %v as redirect but returned %s", defRedirectURL, redirect.URL)
+	}
+	if redirect.Code != http.StatusFound {
+		t.Errorf("Expected %v as redirect to have a code %d but had %d", defRedirectURL, defaultPermanentRedirectCode, redirect.Code)
+	}
+	if redirect.FromToWWW != true {
+		t.Errorf("Expected %v as redirect to have from-to-www as %v but got %v", defRedirectURL, true, redirect.FromToWWW)
+	}
+}
+
+func TestIsValidURL(t *testing.T) {
+
+	invalid := "ok.com"
+	urlParse, err := url.Parse(invalid)
+	if err != nil {
+		t.Errorf("unexpected error %v", err)
+	}
+
+	expected := errors.Errorf("only http and https are valid protocols (%v)", urlParse.Scheme)
+	err = isValidURL(invalid)
+	if reflect.DeepEqual(expected.Error, err.Error) {
+		t.Errorf("expected '%v' but got '%v'", expected, err)
+	}
+
+	valid := "http://ok.com"
+	err = isValidURL(valid)
+	if err != nil {
+		t.Errorf("expected nil but got %v", err)
+	}
+}