DevFW-CICD/ingress-nginx-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Annotations cannot being empty

Browse source
This commit is contained in:
Manuel Alejandro de Brito Fontes 2018-12-02 15:35:12 -03:00
parent f78e2e3849
commit 497246f8ba
No known key found for this signature in database
GPG key ID: 786136016A8BA02A
9 changed files with 28 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

3
internal/ingress/annotations/authreq/main.go
View file

@ -123,9 +123,6 @@ func (a authReq) Parse(ing *extensions.Ingress) (interface{}, error) {
if err != nil {
return nil, err
}
if urlString == "" {
return nil, ing_errors.NewLocationDenied("an empty string is not a valid URL")
}
authURL, err := url.Parse(urlString)
if err != nil {

4
internal/ingress/annotations/authreq/main_test.go
View file

@ -105,6 +105,10 @@ func TestAnnotations(t *testing.T) {
}
continue
}
if err != nil {
t.Errorf("%v: unexpected error: %v", test.title, err)
}
u, ok := i.(*Config)
if !ok {
t.Errorf("%v: expected an External type", test.title)