DevFW-CICD/ingress-nginx-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: Ensure changes in MatchCN annotation are detected (#11529)

Browse source 
Co-authored-by: Wouter Dullaert <wouter.dullaert@exoscale.ch>
This commit is contained in:
k8s-infra-cherrypick-robot 2024-07-02 01:29:41 -07:00 • committed by GitHub
parent 6a111a974b
commit 52f89fa1be
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 55 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
internal/ingress/annotations/authtls/main.go
View file

@ -122,6 +122,9 @@ func (assl1 *Config) Equal(assl2 *Config) bool {
if assl1.PassCertToUpstream != assl2.PassCertToUpstream {
return false
}
if assl1.MatchCN != assl2.MatchCN {
return false
}
return true
}

9
internal/ingress/annotations/authtls/main_test.go
View file

@ -333,6 +333,15 @@ func TestEquals(t *testing.T) {
}
cfg2.PassCertToUpstream = true
// Different MatchCN
cfg1.MatchCN = "CN=(hello-app|goodbye)"
cfg2.MatchCN = "CN=(hello-app)"
result = cfg1.Equal(cfg2)
if result != false {
t.Errorf("Expected false")
}
cfg2.MatchCN = "CN=(hello-app|goodbye)"
// Equal Configs
result = cfg1.Equal(cfg2)
if result != true {