Generate correct output on NumCPU() when using cgroups2 (#11778)

Co-authored-by: Nicholas Orlowsky <nickorlow@nickorlow.com>
This commit is contained in:
Marco Ebert 2024-08-12 23:06:45 +02:00 committed by GitHub
parent c31c9b0d06
commit 596054a2d9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 203 additions and 10 deletions

View file

@ -36,15 +36,42 @@ import (
//
// https://www.kernel.org/doc/Documentation/scheduler/sched-bwc.txt
func NumCPU() int {
return NumCPUWithCustomPath("")
}
func NumCPUWithCustomPath(path string) int {
cpus := runtime.NumCPU()
cgroupPath, err := libcontainercgroups.FindCgroupMountpoint("", "cpu")
if err != nil {
return cpus
cgroupVersionCheckPath := path
if cgroupVersionCheckPath == "" {
cgroupVersionCheckPath = "/sys/fs/cgroup/"
}
cpuQuota := readCgroupFileToInt64(cgroupPath, "cpu.cfs_quota_us")
cpuPeriod := readCgroupFileToInt64(cgroupPath, "cpu.cfs_period_us")
cgroupVersion := GetCgroupVersion(cgroupVersionCheckPath)
cpuQuota := int64(-1)
cpuPeriod := int64(-1)
if cgroupVersion == 1 {
cgroupPath := ""
if path == "" {
cgroupPathRd, err := libcontainercgroups.FindCgroupMountpoint("", "cpu")
if err != nil {
return cpus
}
cgroupPath = cgroupPathRd
} else {
cgroupPath = path
}
cpuQuota = readCgroupFileToInt64(cgroupPath, "cpu.cfs_quota_us")
cpuPeriod = readCgroupFileToInt64(cgroupPath, "cpu.cfs_period_us")
} else if cgroupVersion == 2 {
cgroupPath := "/sys/fs/cgroup/"
if path != "" {
cgroupPath = path
}
cpuQuota, cpuPeriod = readCgroup2FileToInt64Tuple(cgroupPath, "cpu.max")
}
if cpuQuota == -1 || cpuPeriod == -1 {
return cpus
@ -53,16 +80,66 @@ func NumCPU() int {
return int(math.Ceil(float64(cpuQuota) / float64(cpuPeriod)))
}
func readCgroupFileToInt64(cgroupPath, cgroupFile string) int64 {
contents, err := os.ReadFile(filepath.Join(cgroupPath, cgroupFile))
if err != nil {
return -1
func GetCgroupVersion(cgroupPath string) int64 {
// /sys/fs/cgroup/cgroup.controllers will not exist with cgroupsv1
if _, err := os.Stat(filepath.Join(cgroupPath, "cgroup.controllers")); err == nil {
return 2
}
strValue := strings.TrimSpace(string(contents))
return 1
}
func readCgroup2StringToInt64Tuple(cgroupString string) (quota, period int64) {
// file contents looks like: $MAX $PERIOD
// $MAX can have value "max" indicating no limit
// it is possible for $PERIOD to be unset
values := strings.Fields(cgroupString)
if values[0] == "max" {
return -1, -1
}
cpuQuota, err := strconv.ParseInt(values[0], 10, 64)
if err != nil {
return -1, -1
}
if len(values) == 1 {
return cpuQuota, 100000
}
cpuPeriod, err := strconv.ParseInt(values[1], 10, 64)
if err != nil {
return -1, -1
}
return cpuQuota, cpuPeriod
}
func readCgroup2FileToInt64Tuple(cgroupPath, cgroupFile string) (quota, period int64) {
contents, err := os.ReadFile(filepath.Join(cgroupPath, cgroupFile))
if err != nil {
return -1, -1
}
return readCgroup2StringToInt64Tuple(string(contents))
}
func readCgroupStringToInt64(contents string) int64 {
strValue := strings.TrimSpace(contents)
if value, err := strconv.ParseInt(strValue, 10, 64); err == nil {
return value
}
return -1
}
func readCgroupFileToInt64(cgroupPath, cgroupFile string) int64 {
contents, err := os.ReadFile(filepath.Join(cgroupPath, cgroupFile))
if err != nil {
return -1
}
return readCgroupStringToInt64(string(contents))
}