Remove retries to ExternalName (#4584)

This commit is contained in:
Manuel Alejandro de Brito Fontes 2019-09-22 18:16:25 -03:00 committed by GitHub
parent 189e742685
commit 624ce0857a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 28 deletions

View file

@ -21,9 +21,7 @@ import (
"net"
"reflect"
"strconv"
"time"
"k8s.io/apimachinery/pkg/util/wait"
"k8s.io/klog"
corev1 "k8s.io/api/core/v1"
@ -60,26 +58,9 @@ func getEndpoints(s *corev1.Service, port *corev1.ServicePort, proto corev1.Prot
// if the externalName is not an IP address we need to validate is a valid FQDN
if net.ParseIP(s.Spec.ExternalName) == nil {
defaultRetry := wait.Backoff{
Steps: 2,
Duration: 1 * time.Second,
Factor: 1.5,
Jitter: 0.2,
}
var lastErr error
err := wait.ExponentialBackoff(defaultRetry, func() (bool, error) {
_, err := net.LookupHost(s.Spec.ExternalName)
if err == nil {
return true, nil
}
lastErr = err
return false, nil
})
_, err := net.LookupHost(s.Spec.ExternalName)
if err != nil {
klog.Errorf("Error resolving host %q: %v", s.Spec.ExternalName, lastErr)
klog.Errorf("Error resolving host %q: %v", s.Spec.ExternalName, err)
return upsServers
}
}