DevFW-CICD/ingress-nginx-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove retries to ExternalName (#4584)

Browse source
This commit is contained in:
Manuel Alejandro de Brito Fontes 2019-09-22 18:16:25 -03:00 • committed by GitHub
parent 189e742685
commit 624ce0857a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

10
internal/ingress/controller/endpoints_test.go
View file

@ -83,11 +83,11 @@ func TestGetEndpoints(t *testing.T) {
&corev1.Service{
Spec: corev1.ServiceSpec{
Type: corev1.ServiceTypeExternalName,
ExternalName: "www.10.0.0.1.xip.io",
ExternalName: "www.google.com",
Ports: []corev1.ServicePort{
{
Name: "default",
TargetPort: intstr.FromInt(80),
TargetPort: intstr.FromInt(443),
},
},
},
@ -102,13 +102,13 @@ func TestGetEndpoints(t *testing.T) {
},
[]ingress.Endpoint{
{
Address: "www.10.0.0.1.xip.io",
Port: "80",
Address: "www.google.com",
Port: "443",
},
},
},
{
"a service type ServiceTypeExternalName with an invalid ExternalName value should return one endpoint",
"a service type ServiceTypeExternalName with an invalid ExternalName value should no return endpoints",
&corev1.Service{
Spec: corev1.ServiceSpec{
Type: corev1.ServiceTypeExternalName,