DevFW-CICD/ingress-nginx-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

unnecessary use of fmt.Sprint (S1039) (#10049)

Browse source
This commit is contained in:
guangwu 2023-06-12 02:49:54 +08:00 • committed by GitHub
parent 114ae77fb7
commit 7043f6ae29
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 58 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

39
test/e2e/settings/forwarded_headers.go
View file

@ -17,7 +17,6 @@ limitations under the License.
package settings
import (
"fmt"
"net/http"
"strings"
@ -65,12 +64,12 @@ var _ = framework.DescribeSetting("use-forwarded-headers", func() {
Body().
Raw()
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("host=myhost"))
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-host=myhost"))
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-proto=myproto"))
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-scheme=myproto"))
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-port=1234"))
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-for=1.2.3.4"))
assert.Contains(ginkgo.GinkgoT(), body, "host=myhost")
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-host=myhost")
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-proto=myproto")
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-scheme=myproto")
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-port=1234")
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-for=1.2.3.4")
ginkgo.By("ensuring that first entry in X-Forwarded-Host is used as the best host")
body = f.HTTPTestClient().
@ -85,8 +84,8 @@ var _ = framework.DescribeSetting("use-forwarded-headers", func() {
Body().
Raw()
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("host=myhost.com"))
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-host=myhost.com"))
assert.Contains(ginkgo.GinkgoT(), body, "host=myhost.com")
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-host=myhost.com")
})
ginkgo.It("should not trust X-Forwarded headers when setting is false", func() {
@ -115,16 +114,16 @@ var _ = framework.DescribeSetting("use-forwarded-headers", func() {
Body().
Raw()
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("host=forwarded-headers"))
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-port=80"))
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-proto=http"))
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-scheme=http"))
assert.Contains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-original-forwarded-for=1.2.3.4"))
assert.NotContains(ginkgo.GinkgoT(), body, fmt.Sprintf("host=myhost"))
assert.NotContains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-host=myhost"))
assert.NotContains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-proto=myproto"))
assert.NotContains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-scheme=myproto"))
assert.NotContains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-port=1234"))
assert.NotContains(ginkgo.GinkgoT(), body, fmt.Sprintf("x-forwarded-for=1.2.3.4"))
assert.Contains(ginkgo.GinkgoT(), body, "host=forwarded-headers")
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-port=80")
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-proto=http")
assert.Contains(ginkgo.GinkgoT(), body, "x-forwarded-scheme=http")
assert.Contains(ginkgo.GinkgoT(), body, "x-original-forwarded-for=1.2.3.4")
assert.NotContains(ginkgo.GinkgoT(), body, "host=myhost")
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-host=myhost")
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-proto=myproto")
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-scheme=myproto")
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-port=1234")
assert.NotContains(ginkgo.GinkgoT(), body, "x-forwarded-for=1.2.3.4")
})
})