DevFW-CICD/ingress-nginx-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

properly parse x-forwarded-host

Browse source
This commit is contained in:
Elvin Efendi 2019-03-31 13:33:59 -04:00
parent 79431812b6
commit 87e962682f
2 changed files with 28 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

15
rootfs/etc/nginx/lua/lua_ingress.lua
View file

@ -68,6 +68,16 @@ local function redirect_host()
return host_port[1];
end
local function parse_x_forwarded_host()
local hosts, err = ngx_re_split(ngx.var.http_x_forwarded_host, ",")
if err then
ngx.log(ngx.ERR, string_format("could not parse variable: %s", err))
return ""
end
return hosts[1]
end
function _M.init_worker()
randomseed()
end
@ -96,10 +106,7 @@ function _M.rewrite(location_config)
-- Obtain best http host
if ngx.var.http_x_forwarded_host then
-- TODO(elvinefendi) https://github.com/kubernetes/ingress-nginx/issues/3790 can
-- be fixed here by splitting the value of ngx.var.http_x_forwarded_host by ','
-- and taking the first portion
ngx.var.best_http_host = ngx.var.http_x_forwarded_host
ngx.var.best_http_host = parse_x_forwarded_host()
end
end