DevFW-CICD/ingress-nginx-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add golangci github action and replace the deprecated golint (#10187)

Browse source 
* Add golangci github action and replace the deprecated golint

Signed-off-by: z1cheng <imchench@gmail.com>

* Install if golangci-lint not exists

Signed-off-by: z1cheng <imchench@gmail.com>

* Use -z operator

Signed-off-by: z1cheng <imchench@gmail.com>

* Fix json tag for DatadogSampleRate field in config.go

Signed-off-by: z1cheng <imchench@gmail.com>

* Add golangci linters

Signed-off-by: z1cheng <imchench@gmail.com>

* Revert DatadogSampleRate fix

Signed-off-by: z1cheng <imchench@gmail.com>

* Fix comments

Signed-off-by: z1cheng <imchench@gmail.com>

* Add a new line

Signed-off-by: z1cheng <imchench@gmail.com>

* fixup! Add a new line

Signed-off-by: z1cheng <imchench@gmail.com>

* Add trigger condition

Signed-off-by: z1cheng <imchench@gmail.com>

* Add golint-check entry in makefile

Signed-off-by: Chen Chen <imchench@gmail.com>

* Run golint-check in a container

Signed-off-by: Chen Chen <imchench@gmail.com>

---------

Signed-off-by: z1cheng <imchench@gmail.com>
Signed-off-by: Chen Chen <imchench@gmail.com>
This commit is contained in:
Chen Chen 2023-09-07 01:06:53 +08:00 • committed by GitHub
parent c9ca168364
commit 8a6af6068d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 289 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Makefile
View file

@ -128,6 +128,12 @@ static-check: ## Run verification script for boilerplate, codegen, gofmt, golint
MAC_OS=$(MAC_OS) \
hack/verify-all.sh
.PHONY: golint-check
golint-check:
@build/run-in-docker.sh \
MAC_OS=$(MAC_OS) \
hack/verify-golint.sh
###############################
# Tests for ingress-nginx
###############################