DevFW-CICD/ingress-nginx-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #3764 from ElvinEfendi/cleanup-confusing-attribute

Browse source 
delete confusing CustomErrors attribute to make things more explicit
This commit is contained in:
Kubernetes Prow Robot 2019-02-14 03:26:21 -08:00 • committed by GitHub
commit 908a2ae506
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
internal/ingress/controller/config/config.go
View file

@ -721,7 +721,6 @@ type TemplateConfig struct {
TCPBackends []ingress.L4Service
UDPBackends []ingress.L4Service
HealthzURI string
CustomErrors bool
Cfg Configuration
IsIPV6Enabled bool
IsSSLPassthroughEnabled bool

1
internal/ingress/controller/nginx.go
View file

@ -596,7 +596,6 @@ func (n *NGINXController) OnUpdate(ingressCfg ingress.Configuration) error {
Servers: ingressCfg.Servers,
TCPBackends: ingressCfg.TCPEndpoints,
UDPBackends: ingressCfg.UDPEndpoints,
CustomErrors: len(cfg.CustomHTTPErrors) > 0,
Cfg: cfg,
IsIPV6Enabled: n.isIPV6Enabled && !cfg.DisableIpv6,
NginxStatusIpv4Whitelist: cfg.NginxStatusIpv4Whitelist,