DevFW-CICD/ingress-nginx-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix golangci-lint errors (#10196)

Browse source 
* Fix golangci-lint errors

Signed-off-by: z1cheng <imchench@gmail.com>

* Fix dupl errors

Signed-off-by: z1cheng <imchench@gmail.com>

* Fix comments

Signed-off-by: z1cheng <imchench@gmail.com>

* Fix errcheck lint errors

Signed-off-by: z1cheng <imchench@gmail.com>

* Fix assert in e2e test

Signed-off-by: z1cheng <imchench@gmail.com>

* Not interrupt the waitForPodsReady

Signed-off-by: z1cheng <imchench@gmail.com>

* Replace string with constant

Signed-off-by: z1cheng <imchench@gmail.com>

* Fix comments

Signed-off-by: z1cheng <imchench@gmail.com>

* Revert write file permision

Signed-off-by: z1cheng <imchench@gmail.com>

---------

Signed-off-by: z1cheng <imchench@gmail.com>
This commit is contained in:
Chen Chen 2023-08-31 15:36:48 +08:00 • committed by GitHub
parent 46d87d3462
commit b3060bfbd0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
253 changed files with 2434 additions and 2113 deletions
Download patch file Download diff file Expand all files Collapse all files

1
internal/ingress/inspector/ingress_test.go
View file

@ -24,7 +24,6 @@ import (
)
func makeSimpleIngress(hostname string, paths ...string) *networking.Ingress {
newIngress := networking.Ingress{
ObjectMeta: v1.ObjectMeta{
Name: "test1",

4
internal/ingress/inspector/inspector.go
View file

@ -40,9 +40,7 @@ func DeepInspect(obj interface{}) error {
}
}
var (
implSpecific = networking.PathTypeImplementationSpecific
)
var implSpecific = networking.PathTypeImplementationSpecific
func ValidatePathType(ing *networking.Ingress) error {
if ing == nil {

6
internal/ingress/inspector/rules.go
View file

@ -34,7 +34,7 @@ var (
// the group [[:alnum:]\_\-\/]* says that any amount of characters (A-Za-z0-9), _, - and /
// are accepted until the end of the line
// Nothing else is accepted.
validPathType = regexp.MustCompile(`(?i)^/[[:alnum:]\_\-\/]*$`)
validPathType = regexp.MustCompile(`(?i)^/[[:alnum:]\_\-/]*$`)
invalidRegex = []regexp.Regexp{}
)
@ -52,8 +52,8 @@ func init() {
// CheckRegex receives a value/configuration and validates if it matches with one of the
// forbidden regexes.
func CheckRegex(value string) error {
for _, regex := range invalidRegex {
if regex.MatchString(value) {
for i := range invalidRegex {
if invalidRegex[i].MatchString(value) {
return fmt.Errorf("invalid value found: %s", value)
}
}

1
internal/ingress/inspector/rules_test.go
View file

@ -19,7 +19,6 @@ package inspector
import "testing"
func TestCheckRegex(t *testing.T) {
tests := []struct {
name string
value string

2
internal/ingress/inspector/service.go
View file

@ -21,6 +21,6 @@ import (
)
// InspectService will be used to inspect service objects for possible invalid configurations
func InspectService(svc *corev1.Service) error {
func InspectService(_ *corev1.Service) error {
return nil
}