DevFW-CICD/ingress-nginx-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix golangci-lint errors (#10196)

Browse source 
* Fix golangci-lint errors

Signed-off-by: z1cheng <imchench@gmail.com>

* Fix dupl errors

Signed-off-by: z1cheng <imchench@gmail.com>

* Fix comments

Signed-off-by: z1cheng <imchench@gmail.com>

* Fix errcheck lint errors

Signed-off-by: z1cheng <imchench@gmail.com>

* Fix assert in e2e test

Signed-off-by: z1cheng <imchench@gmail.com>

* Not interrupt the waitForPodsReady

Signed-off-by: z1cheng <imchench@gmail.com>

* Replace string with constant

Signed-off-by: z1cheng <imchench@gmail.com>

* Fix comments

Signed-off-by: z1cheng <imchench@gmail.com>

* Revert write file permision

Signed-off-by: z1cheng <imchench@gmail.com>

---------

Signed-off-by: z1cheng <imchench@gmail.com>
This commit is contained in:
Chen Chen 2023-08-31 15:36:48 +08:00 • committed by GitHub
parent 46d87d3462
commit b3060bfbd0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
253 changed files with 2434 additions and 2113 deletions
Download patch file Download diff file Expand all files Collapse all files

40
internal/ingress/metric/dummy.go
View file

@ -29,50 +29,50 @@ func NewDummyCollector() Collector {
// DummyCollector dummy implementation for mocks in tests
type DummyCollector struct{}
// ConfigSuccess ...
// ConfigSuccess dummy implementation
func (dc DummyCollector) ConfigSuccess(uint64, bool) {}
// SetAdmissionMetrics ...
// SetAdmissionMetrics dummy implementation
func (dc DummyCollector) SetAdmissionMetrics(float64, float64, float64, float64, float64, float64) {}
// IncReloadCount ...
// IncReloadCount dummy implementation
func (dc DummyCollector) IncReloadCount() {}
// IncReloadErrorCount ...
// IncReloadErrorCount dummy implementation
func (dc DummyCollector) IncReloadErrorCount() {}
// IncOrphanIngress ...
// IncOrphanIngress dummy implementation
func (dc DummyCollector) IncOrphanIngress(string, string, string) {}
// DecOrphanIngress ...
// DecOrphanIngress dummy implementation
func (dc DummyCollector) DecOrphanIngress(string, string, string) {}
// IncCheckCount ...
// IncCheckCount dummy implementation
func (dc DummyCollector) IncCheckCount(string, string) {}
// IncCheckErrorCount ...
// IncCheckErrorCount dummy implementation
func (dc DummyCollector) IncCheckErrorCount(string, string) {}
// RemoveMetrics ...
func (dc DummyCollector) RemoveMetrics(ingresses, endpoints, certificates []string) {}
// RemoveMetrics dummy implementation
func (dc DummyCollector) RemoveMetrics(_, _, _ []string) {}
// Start ...
func (dc DummyCollector) Start(admissionStatus string) {}
// Start dummy implementation
func (dc DummyCollector) Start(_ string) {}
// Stop ...
func (dc DummyCollector) Stop(admissionStatus string) {}
// Stop dummy implementation
func (dc DummyCollector) Stop(_ string) {}
// SetSSLInfo ...
// SetSSLInfo dummy implementation
func (dc DummyCollector) SetSSLInfo([]*ingress.Server) {}
// SetSSLExpireTime ...
// SetSSLExpireTime dummy implementation
func (dc DummyCollector) SetSSLExpireTime([]*ingress.Server) {}
// SetHosts ...
func (dc DummyCollector) SetHosts(hosts sets.Set[string]) {}
// SetHosts dummy implementation
func (dc DummyCollector) SetHosts(_ sets.Set[string]) {}
// OnStartedLeading indicates the pod is not the current leader
func (dc DummyCollector) OnStartedLeading(electionID string) {}
func (dc DummyCollector) OnStartedLeading(_ string) {}
// OnStoppedLeading indicates the pod is not the current leader
func (dc DummyCollector) OnStoppedLeading(electionID string) {}
func (dc DummyCollector) OnStoppedLeading(_ string) {}