Lint code

core/pkg/base64/base64.go

@@ -5,8 +5,8 @@ import (
 	"strings"
 )
 
-// Base64Encode
-func Base64Encode(s string) string {
+// Encode encodes a string to base64 removing the equals character
+func Encode(s string) string {
 	str := base64.URLEncoding.EncodeToString([]byte(s))
 	return strings.Replace(str, "=", "", -1)
 }

core/pkg/ingress/annotations/authreq/main.go

@@ -160,7 +160,7 @@ func (a authReq) Parse(ing *extensions.Ingress) (interface{}, error) {
 
 		harr := strings.Split(hstr, ",")
 		for _, header := range harr {
-			header := strings.TrimSpace(header)
+			header = strings.TrimSpace(header)
 			if len(header) > 0 {
 				if !validHeader(header) {
 					return nil, ing_errors.NewLocationDenied("invalid headers list")

core/pkg/ingress/annotations/ratelimit/main.go

@@ -218,7 +218,7 @@ func (a ratelimit) Parse(ing *extensions.Ingress) (interface{}, error) {
 		LimitRate:      lr,
 		LimitRateAfter: lra,
 		Name:           zoneName,
-		ID:             base64.Base64Encode(zoneName),
+		ID:             base64.Encode(zoneName),
 		Whitelist:      cidrs,
 	}, nil
 }

core/pkg/ingress/controller/controller.go

@@ -1015,7 +1015,7 @@ func (ic *GenericController) createServers(data []interface{},
 		fakeCertificatePath := fmt.Sprintf("%v/%v.pem", ingress.DefaultSSLDirectory, fakeCertificate)
 
 		// Only generates a new certificate if it doesn't exists physically
-		_, err := os.Stat(fakeCertificatePath)
+		_, err = os.Stat(fakeCertificatePath)
 		if err != nil {
 			glog.V(3).Infof("No Default SSL Certificate found. Generating a new one")
 			defCert, defKey := ssl.GetFakeSSLCert()

core/pkg/net/ssl/ssl_test.go

@@ -28,11 +28,6 @@ import (
 	"k8s.io/ingress/core/pkg/ingress"
 )
 
-const (
-	rsaBits  = 2048
-	validFor = 365 * 24 * time.Hour
-)
-
 // generateRSACerts generates a self signed certificate using a self generated ca
 func generateRSACerts(host string) (*triple.KeyPair, *triple.KeyPair, error) {
 	ca, err := triple.NewCA("self-sign-ca")