Enable lj-releng tool to lint lua code.

rootfs/etc/nginx/lua/util/dns.lua

@@ -13,7 +13,8 @@ local tostring = tostring
 
 local _M = {}
 local CACHE_SIZE = 10000
-local MAXIMUM_TTL_VALUE = 2147483647 -- maximum value according to https://tools.ietf.org/html/rfc2181
+-- maximum value according to https://tools.ietf.org/html/rfc2181
+local MAXIMUM_TTL_VALUE = 2147483647
 -- for every host we will try two queries for the following types with the order set here
 local QTYPES_TO_CHECK = { resolver.TYPE_A, resolver.TYPE_AAAA }
 
@@ -59,7 +60,8 @@ local function resolve_host_for_qtype(r, host, qtype)
   end
 
   if answers.errcode then
-    return nil, -1, string_format("server returned error code: %s: %s", answers.errcode, answers.errstr)
+    return nil, -1, string_format("server returned error code: %s: %s",
+      answers.errcode, answers.errstr)
   end
 
   local addresses, ttl = a_records_and_min_ttl(answers)
@@ -116,7 +118,8 @@ function _M.lookup(host)
       return addresses
     end
 
-    ngx_log(ngx_ERR, "failed to query the DNS server for ", host, ":\n", table_concat(dns_errors, "\n"))
+    ngx_log(ngx_ERR, "failed to query the DNS server for ",
+      host, ":\n", table_concat(dns_errors, "\n"))
 
     return { host }
   end
@@ -135,7 +138,8 @@ function _M.lookup(host)
   end
 
   for i = search_start, search_end, 1 do
-    local new_host = resolv_conf.search[i] and string_format("%s.%s", host, resolv_conf.search[i]) or host
+    local new_host = resolv_conf.search[i] and
+      string_format("%s.%s", host, resolv_conf.search[i]) or host
 
     addresses, ttl, dns_errors = resolve_host(r, new_host)
     if addresses then
@@ -145,14 +149,13 @@ function _M.lookup(host)
   end
 
   if #dns_errors > 0 then
-    ngx_log(ngx_ERR, "failed to query the DNS server for ", host, ":\n", table_concat(dns_errors, "\n"))
+    ngx_log(ngx_ERR, "failed to query the DNS server for ",
+      host, ":\n", table_concat(dns_errors, "\n"))
   end
 
   return { host }
 end
 
-if _TEST then
-  _M._cache = cache
-end
+setmetatable(_M, {__index = { _cache = cache }})
 
 return _M

rootfs/etc/nginx/lua/util/nodemap.lua

@@ -1,5 +1,9 @@
 local math_random = require("math").random
 local util_tablelength = require("util").tablelength
+local ngx = ngx
+local pairs = pairs
+local string = string
+local setmetatable = setmetatable
 
 local _M = {}
 
@@ -41,7 +45,8 @@ local function get_random_node(map)
       count = count + 1
   end
 
-  ngx.log(ngx.ERR, string.format("Failed to find node %d of %d! This is a bug, please report!", index, size))
+  ngx.log(ngx.ERR, string.format("Failed to find node %d of %d! "
+    .. "This is a bug, please report!", index, size))
 
   return nil, nil
 end
@@ -55,7 +60,8 @@ end
 -- To make sure hash keys are reproducible on different ingress controller instances the salt
 -- needs to be shared and therefore is not simply generated randomly.
 --
--- @tparam {[string]=number} endpoints A table with the node endpoint as a key and its weight as a value.
+-- @tparam {[string]=number} endpoints A table with the node endpoint
+-- as a key and its weight as a value.
 -- @tparam[opt] string hash_salt A optional hash salt that will be used to obfuscate the hash key.
 function _M.new(self, endpoints, hash_salt)
   if hash_salt == nil then

rootfs/etc/nginx/lua/util/resolv_conf.lua

@@ -1,5 +1,6 @@
 local ngx_re_split = require("ngx.re").split
 local string_format = string.format
+local tonumber = tonumber
 
 local ngx_log = ngx.log
 local ngx_ERR = ngx.ERR

rootfs/etc/nginx/lua/util/same_site.lua

@@ -1,3 +1,5 @@
+local string = string
+
 local _M = {}
 
 -- determines whether to apply a SameSite=None attribute

rootfs/etc/nginx/lua/util/split.lua

@@ -1,3 +1,5 @@
+local ipairs = ipairs
+
 local _M = {}
 
 -- splits strings into host and port
@@ -34,7 +36,8 @@ function _M.split_upstream_var(var)
   return t
 end
 
--- Splits an NGINX $upstream_addr and returns an array of tables with a `host` and `port` key-value pair.
+-- Splits an NGINX $upstream_addr and returns an array of tables
+-- with a `host` and `port` key-value pair.
 function _M.split_upstream_addr(addrs_str)
   if not addrs_str then
     return nil, nil