DevFW-CICD/ingress-nginx-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

use functional options to reduce number of methods creating an EchoDeployment (#8199)

Browse source
This commit is contained in:
Damien Mathieu 2022-02-02 14:12:22 +01:00 • committed by GitHub
parent 0f464333a9
commit dcd552ceb5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
20 changed files with 75 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/e2e/annotations/customhttperrors.go
View file

@ -101,7 +101,7 @@ var _ = framework.DescribeAnnotation("custom-http-errors", func() {
ginkgo.By("using the custom default-backend from annotation for upstream")
customDefaultBackend := "from-annotation"
f.NewEchoDeploymentWithNameAndReplicas(customDefaultBackend, 1)
f.NewEchoDeployment(framework.WithDeploymentName(customDefaultBackend))
err = framework.UpdateIngress(f.KubeClientSet, f.Namespace, host, func(ingress *networking.Ingress) error {
ingress.ObjectMeta.Annotations["nginx.ingress.kubernetes.io/default-backend"] = customDefaultBackend