DevFW-CICD/ingress-nginx-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

use functional options to reduce number of methods creating an EchoDeployment (#8199)

Browse source
This commit is contained in:
Damien Mathieu 2022-02-02 14:12:22 +01:00 • committed by GitHub
parent 0f464333a9
commit dcd552ceb5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
20 changed files with 75 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

7
test/e2e/lua/dynamic_configuration.go
View file

@ -43,7 +43,7 @@ var _ = framework.IngressNginxDescribe("[Lua] dynamic configuration", func() {
f := framework.NewDefaultFramework("dynamic-configuration")
ginkgo.BeforeEach(func() {
f.NewEchoDeploymentWithReplicas(1)
f.NewEchoDeployment()
ensureIngress(f, "foo.com", framework.EchoService)
})
@ -124,7 +124,10 @@ var _ = framework.IngressNginxDescribe("[Lua] dynamic configuration", func() {
ginkgo.It("handles endpoints only changes consistently (down scaling of replicas vs. empty service)", func() {
deploymentName := "scalingecho"
f.NewEchoDeploymentWithNameAndReplicas(deploymentName, 0)
f.NewEchoDeployment(
framework.WithDeploymentName(deploymentName),
framework.WithDeploymentReplicas(0),
)
createIngress(f, "scaling.foo.com", deploymentName)
resp := f.HTTPTestClient().