Lint shell scripts

build/run-in-docker.sh

@@ -14,8 +14,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-if ! [ -z $DEBUG ]; then
-	set -x
+if [ -n "$DEBUG" ]; then
+  set -x
 fi
 
 set -o errexit
@@ -24,7 +24,7 @@ set -o pipefail
 
 E2E_IMAGE=quay.io/kubernetes-ingress-controller/e2e:v06262019-ecce3fd7b
 
-DOCKER_OPTS=${DOCKER_OPTS:-""}
+DOCKER_OPTS=${DOCKER_OPTS:-}
 
 FLAGS=$@
 
@@ -33,20 +33,21 @@ ARCH=$(go env GOARCH)
 
 MINIKUBE_PATH=${HOME}/.minikube
 MINIKUBE_VOLUME="-v ${MINIKUBE_PATH}:${MINIKUBE_PATH}"
-if [ ! -d ${MINIKUBE_PATH} ]; then
+if [ ! -d "${MINIKUBE_PATH}" ]; then
     echo "Minikube directory not found! Volume will be excluded from docker build."
     MINIKUBE_VOLUME=""
 fi
 
 docker run                                       \
-    --tty                                        \
-    --rm                                         \
-    ${DOCKER_OPTS}                               \
-    -v ${HOME}/.kube:/${HOME}/.kube              \
-    -v ${PWD}:/go/src/${PKG}                     \
-    -v ${PWD}/.gocache:${HOME}/.cache/go-build   \
-    -v ${PWD}/bin/${ARCH}:/go/bin/linux_${ARCH}  \
-    -v /var/run/docker.sock:/var/run/docker.sock \
-    ${MINIKUBE_VOLUME}                           \
-    -w /go/src/${PKG}                            \
-    ${E2E_IMAGE} ${FLAGS}
+  --tty                                          \
+  --rm                                           \
+  ${DOCKER_OPTS}                                 \
+  -v "${HOME}/.kube:${HOME}/.kube"               \
+  -v "${PWD}:/go/src/${PKG}"                     \
+  -v "${PWD}/.gocache:${HOME}/.cache/go-build"   \
+  -v "${PWD}/bin/${ARCH}:/go/bin/linux_${ARCH}"  \
+  -v "/var/run/docker.sock:/var/run/docker.sock" \
+  ${MINIKUBE_VOLUME}                             \
+  -w "/go/src/${PKG}"                            \
+  -u $(id -u ${USER}):$(id -g ${USER})           \
+  ${E2E_IMAGE} /bin/bash -c "${FLAGS}"