DevFW-CICD/ingress-nginx-helm
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

config: use *float32 with nil instead of float32 with sentinel value

Browse source
This commit is contained in:
David Goffredo 2023-06-27 22:45:50 +00:00 • committed by k8s-infra-cherrypick-robot
parent 059f6262fe
commit fb1dcff2f3
2 changed files with 5 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

7
internal/ingress/controller/nginx.go
View file

@ -1083,12 +1083,11 @@ func datadogOpentracingCfg(cfg ngx_config.Configuration) (string, error) {
"operation_name_override": cfg.DatadogOperationNameOverride,
}
// Omit "sample_rate" if the configuration's sample rate is set to the
// default sentinel value DatadogDynamicSampleRate (-1).
// Omit "sample_rate" if the configuration's sample rate is unset (nil).
// Omitting "sample_rate" from the plugin JSON indicates to the tracer that
// it should use dynamic rates instead of a configured rate.
if cfg.DatadogSampleRate != ngx_config.DatadogDynamicSampleRate {
jsn["sample_rate"] = cfg.DatadogSampleRate
if cfg.DatadogSampleRate != nil {
jsn["sample_rate"] = *cfg.DatadogSampleRate
}
jsnBytes, err := json.Marshal(jsn)